Should You Review Senior Colleagues’ Pull Requests?

Опубликовано: 10 Июнь 2024
на канале: mostdevwill
20
1

Should You Review Senior Colleagues’ Pull Requests?

Definitely!

Let me give you a personal example. I believe I can say that I’m a Senior Developer. You probably remember that I’m a Tech Lead now. This role means that I’m still involved in some interesting technical stuff, but I don’t have time to write code myself.

Recently, I found myself in a situation where I had to implement a solution. The task was out of scope of our services, and I knew all the necessary details. So I decided it would be faster if I just implemented the feature myself.

During my regular Tech Lead work, I have to review a lot of PRs. But does that mean I’m the “master” who knows how to deliver the best code that won’t have a single comment during the PR review?

Of course not!

The more senior a developer becomes, the more they hesitate and prefer not to trust themselves. Instead, they rely on automation tools like unit testing and CI pipelines. But they also value the opinions of their colleagues.

The reason is that colleagues are not “tired of the task”; they are not biased against it. They can review the code cold-headed. And you know what? They left a couple of comments, indeed.

This doesn’t mean I’m a “stupid senior who doesn’t know how to write code.” It just means I’m a human who doesn’t want to trust myself blindly because I know the consequences.

So, don’t be shy to ask your colleagues for PR reviews, even the less experienced ones.

If you want more insights about Tech Leading and Software Development, follow me! ✅

#softwareengineer #programming #coding


Смотрите видео Should You Review Senior Colleagues’ Pull Requests? онлайн без регистрации, длительностью часов минут секунд в хорошем качестве. Это видео добавил пользователь mostdevwill 10 Июнь 2024, не забудьте поделиться им ссылкой с друзьями и знакомыми, на нашем сайте его посмотрели 20 раз и оно понравилось 1 людям.